Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-controls: Add examples to angular, ember, html, svelte, vue, web-components #11197

Merged
merged 12 commits into from
Jun 16, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 16, 2020

Issue: #10799

What I did

How to test

See updated snapshots

@shilman shilman added maintenance User-facing maintenance tasks args addon: controls labels Jun 16, 2020
@shilman shilman added this to the 6.0 args milestone Jun 16, 2020
@shilman shilman changed the title Addon-controls: Framework examples Addon-docs: MDX support for .bind idiom / framework controls examples Jun 16, 2020
@shilman shilman changed the title Addon-docs: MDX support for .bind idiom / framework controls examples Addon-docs: MDX support for Args .bind idiom Jun 16, 2020
@shilman shilman removed the maintenance User-facing maintenance tasks label Jun 16, 2020
@shilman shilman changed the title Addon-docs: MDX support for Args .bind idiom Addon-docs: MDX support for Args .bind({}) idiom Jun 16, 2020
@shilman shilman changed the title Addon-docs: MDX support for Args .bind({}) idiom Addon-docs: Add Args .bind({}) support to MDX w/ examples Jun 16, 2020
@shilman shilman changed the title Addon-docs: Add Args .bind({}) support to MDX w/ examples Aargs: Add .bind({}) support to MDX w/ examples Jun 16, 2020
@shilman shilman changed the title Aargs: Add .bind({}) support to MDX w/ examples Aargs: Add .bind support to MDX w/ examples Jun 16, 2020
@shilman shilman added maintenance User-facing maintenance tasks and removed addon: docs feature request labels Jun 16, 2020
@shilman shilman changed the title Aargs: Add .bind support to MDX w/ examples Addon-controls: Add examples to angular, ember, html, svelte, vue, web-components Jun 16, 2020
@shilman
Copy link
Member Author

shilman commented Jun 16, 2020

Self-merging @tmeasday

@shilman shilman merged commit 14dde8c into next Jun 16, 2020
@shilman shilman mentioned this pull request Jun 16, 2020
12 tasks

<Preview>
<Story
name="Rounded"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to say this is super helpful, @shilman, as someone who's been trying out the beta versions in our large-ish Vue storybook, & trying to get args + .mdx working. Thank you!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup a big thanks from me too, trying to get examples of different plugins working MDX and vue has been a real pain. As knobs stopped working in v6 I moved over to controls, this is a great example and made my life way easier, thanks @shilman

Copy link
Member Author

@shilman shilman Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did knobs stop working? Is there an open issue i can look at? Thanks! @piemasters

Copy link

@piemasters piemasters Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman I'm not sure at what point it stopped working (I'm sure it worked at some point in v6, I can always checkout old versions and test as I tend to update each week). Knobs still worked for standard Web elements, but not as props for vue components.

Components started complaining that all props were strings. While debugging I found that even for components with just string props the components weren't being updated when updating the knob and the default values from the component were being used over the default knob values.

I wasn't sure if it was something to do with my configuration, or if knobs had dropped support for vue for v6 in favour of this addon so I didn't raise an issue.

If I get time tomorrow (otherwise Monday) I'll see at what point it broke and let you know. It should be really simple to create an example from the kitchen sink to test it

@stof stof deleted the 10799-args-examples branch May 25, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: controls args maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants