-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-controls: Add examples to angular, ember, html, svelte, vue, web-components #11197
Conversation
.bind({})
idiom
.bind({})
idiom.bind({})
support to MDX w/ examples
.bind({})
support to MDX w/ examples.bind({})
support to MDX w/ examples
.bind({})
support to MDX w/ examples.bind
support to MDX w/ examples
.bind
support to MDX w/ examples
Self-merging @tmeasday |
|
||
<Preview> | ||
<Story | ||
name="Rounded" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to say this is super helpful, @shilman, as someone who's been trying out the beta versions in our large-ish Vue storybook, & trying to get args + .mdx working. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup a big thanks from me too, trying to get examples of different plugins working MDX and vue has been a real pain. As knobs stopped working in v6 I moved over to controls, this is a great example and made my life way easier, thanks @shilman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did knobs stop working? Is there an open issue i can look at? Thanks! @piemasters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman I'm not sure at what point it stopped working (I'm sure it worked at some point in v6, I can always checkout old versions and test as I tend to update each week). Knobs still worked for standard Web elements, but not as props for vue components.
Components started complaining that all props were strings. While debugging I found that even for components with just string props the components weren't being updated when updating the knob and the default values from the component were being used over the default knob values.
I wasn't sure if it was something to do with my configuration, or if knobs had dropped support for vue for v6 in favour of this addon so I didn't raise an issue.
If I get time tomorrow (otherwise Monday) I'll see at what point it broke and let you know. It should be really simple to create an example from the kitchen sink to test it
Issue: #10799
What I did
Update MDX compiler to support(split into MDX: Support function.bind({}) syntax #11198).bind()
idiomHow to test
See updated snapshots